[Commits] 651a43e: MDEV-18782 mysqldump --all-databases causes segmentation fault.

Alexey Botchkov holyfoot at askmonty.org
Tue May 7 15:15:49 EEST 2019


revision-id: 651a43e0a0361098c35164a128ca588a2989d8e1 (mariadb-10.3.12-178-g651a43e)
parent(s): 26cb9f75eeca7d4f3c9a345746f20456ff4b5ad8
committer: Alexey Botchkov
timestamp: 2019-05-07 16:13:53 +0400
message:

MDEV-18782 mysqldump --all-databases causes segmentation fault.

Do not consider rows of Information_schema.files where
LOGFILE_GROUP_NAME is NULL.

---
 client/mysqldump.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/client/mysqldump.c b/client/mysqldump.c
index a2ed3c0..cbb3a7d 100644
--- a/client/mysqldump.c
+++ b/client/mysqldump.c
@@ -4298,7 +4298,8 @@ static int dump_tablespaces(char* ts_where)
                       " EXTRA"
                       " FROM INFORMATION_SCHEMA.FILES"
                       " WHERE FILE_TYPE = 'UNDO LOG'"
-                      " AND FILE_NAME IS NOT NULL",
+                      " AND FILE_NAME IS NOT NULL"
+                      " AND LOGFILE_GROUP_NAME IS NOT NULL",
                       256, 1024);
   if(ts_where)
   {
@@ -4313,7 +4314,7 @@ static int dump_tablespaces(char* ts_where)
   }
   dynstr_append_checked(&sqlbuf,
                 " GROUP BY LOGFILE_GROUP_NAME, FILE_NAME"
-                ", ENGINE"
+                ", ENGINE, TOTAL_EXTENTS, INITIAL_SIZE"
                 " ORDER BY LOGFILE_GROUP_NAME");
 
   if (mysql_query(mysql, sqlbuf.str) ||


More information about the commits mailing list