[Commits] b69dd5a30eb: avoid Field::store( double );

Oleksandr Byelkin sanja at mariadb.com
Fri May 3 18:13:48 EEST 2019


revision-id: b69dd5a30eba65b9fbe1e78409bc106b4c3844e5 (mariadb-10.2.23-109-gb69dd5a30eb)
parent(s): 91a54d973cfc69e728f8220cdcd5645ee550a682
author: Oleksandr Byelkin
committer: Oleksandr Byelkin
timestamp: 2019-05-03 17:13:48 +0200
message:

avoid Field::store( double );

---
 sql/item_sum.cc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sql/item_sum.cc b/sql/item_sum.cc
index 640ff315438..b1b22d0877f 100644
--- a/sql/item_sum.cc
+++ b/sql/item_sum.cc
@@ -3555,7 +3555,7 @@ bool Item_func_group_concat::add()
   if (row_eligible && tree)
   {
     THD *thd= table->in_use;
-    table->field[0]->store(row_str_len);
+    table->field[0]->store(row_str_len, FALSE);
     if (tree_len > thd->variables.group_concat_max_len * GCONCAT_REPACK_FACTOR
         && tree->elements_in_tree > 1)
       if (repack_tree(thd))
@@ -3703,7 +3703,7 @@ bool Item_func_group_concat::setup(THD *thd)
       of this row. Used to detect when the tree goes over group_concat_max_len
     */
     Item *item= new (thd->mem_root)
-                    Item_int(thd, thd->variables.group_concat_max_len);
+                    Item_uint(thd, thd->variables.group_concat_max_len);
     if (!item || all_fields.push_front(item, thd->mem_root))
       DBUG_RETURN(TRUE);
   }


More information about the commits mailing list