[Commits] d3534d5: MDEV-19351 statistics_for_command_is_needed: Conditional jump or move

IgorBabaev igor at mariadb.com
Sun Apr 28 07:31:04 EEST 2019

revision-id: d3534d5b45a419260d0292d72a6a21f2a2ba2582 (mariadb-10.1.38-144-gd3534d5)
parent(s): d88dfd873232dafd480c2d0382b4ff3add9c936d
author: Igor Babaev
committer: Igor Babaev
timestamp: 2019-04-27 21:31:04 -0700

MDEV-19351 statistics_for_command_is_needed: Conditional jump or move
           depends on uninitialised value

Initialized THD::force_read_stats introduced in the patch for MDEV-17605.
Leaving this field uninitialized in the constructor of the THD class may
trigger reading statistical data that is not needed.

 sql/sql_class.cc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sql/sql_class.cc b/sql/sql_class.cc
index 639c7c1..6fa8c10 100644
--- a/sql/sql_class.cc
+++ b/sql/sql_class.cc
@@ -983,6 +983,7 @@ THD::THD(bool is_wsrep_applier)
   memset(&invoker_host, 0, sizeof(invoker_host));
   prepare_derived_at_open= FALSE;
   create_tmp_table_for_derived= FALSE;
+  force_read_stats= FALSE;
   save_prep_leaf_list= FALSE;
   /* Restore THR_THD */

More information about the commits mailing list