[Commits] 97037da: Replace static usage of AES_CTR with current encryption algorithm.

Jan Lindström jan.lindstrom at mariadb.com
Tue Mar 17 20:09:27 EET 2015


Hi,

On Tue, Mar 17, 2015 at 8:05 PM, Jeremy Cole <jeremycole at google.com> wrote:

> Jan,
>
>
>> -  my_aes_init_dynamic_encrypt(MY_AES_ALGORITHM_CTR);
>> +  if (current_aes_dynamic_method == MY_AES_ALGORITHM_NONE)
>> +  {
>> +    sql_print_error("No encryption method choosen with
>> --encryption-algorithm. "
>> +                    "example_key_management_plugin disabled");
>> +    return 1;
>> +  }
>>
>
> I don't get it. Why is example_key_management_plugin special here? If
> you're going to support "none", why not here as well?
>

This is exactly similar to file_key_management_plugin i.e. do not
initialize if NONE.

>
>
>> +
>> +  my_aes_init_dynamic_encrypt(current_aes_dynamic_method);
>>
>
> Isn't this redundant? It should already be initialized by the call in
> init_server_components...
>
>
>
Maybe, but what if you load this plugin after server has started ?

R: Jan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.askmonty.org/pipermail/commits/attachments/20150317/38c66fdf/attachment.html>


More information about the commits mailing list