[Commits] 1504890: MDEV-7384: Add --persistent option for mysqlcheck'

Sergey Petrunia sergey at mariadb.com
Wed Dec 16 20:38:57 EET 2015


Hi Vicențiu,

On Tue, Dec 15, 2015 at 02:15:55PM +0000, Vicențiu Ciorbaru wrote:
> Can you please review this patch? It is the original one from Daniel Black
> to which I've added a test case. I'm ok with the extended functionality for
> mysqlcheck, however I would personally also add the possibility to have
> persistent for <columns, indices>. How we would implement that however is
> something that we would probably want to discuss.
>
Ok to push.

When I was looking at the patch, I had another idea: add something to specify
whether/what histogram should be collected.

On the other hand, what is the use case for mysqlcheck? Why can't one connect
to the server and run whatever SQL they prefer?

Also, the functions puts query into the buffer defined as " options[100], "
which looks scary.

I think, we should push the patch as is first, and discuss further improvements
separately.

BR
 Sergei
-- 
Sergei Petrunia, Software Developer
MariaDB Corporation | Skype: sergefp | Blog: http://s.petrunia.net/blog




More information about the commits mailing list