[Commits] 305dd8e: Better comments

Sergei Petrunia psergey at askmonty.org
Fri Nov 21 19:45:18 EET 2014


revision-id: 305dd8e5fba804d8006d34ca7cb05bec5a3b45e6
parent(s): 1f3724a5831cd6529f4917b0a977d456465c68fe
committer: Sergei Petrunia
branch nick: 10.1-explain-json-r4
timestamp: 2014-11-21 20:45:18 +0300
message:

Better comments

---
 sql/sql_select.h |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/sql/sql_select.h b/sql/sql_select.h
index 41ee2cb..cf3e1b3 100644
--- a/sql/sql_select.h
+++ b/sql/sql_select.h
@@ -982,7 +982,13 @@ class JOIN :public Sql_alloc
   */
   uint     top_join_tab_count;
   uint	   send_group_parts;
-  bool	   group;          /**< If query contains GROUP BY clause */
+  /*
+    True if the query has GROUP BY.
+    (that is, if group_by != NULL. when DISTINCT is converted into GROUP BY, it
+     will set this, too. It is not clear why we need a separate var from 
+     group_list)
+  */
+  bool	   group;
   bool     need_distinct;
 
   /**


More information about the commits mailing list