[Commits] Rev 4346: MDEV-7026 - Occasional hang during startup on Power8 in lp:maria/5.5

Jonas Oreland jonaso at google.com
Tue Nov 18 10:43:13 EET 2014


>
>   Since isync is not a memory barrier and lwsync doesn't guarantee
> StoreLoad
>   order, the only option we have is full memory barrier.
> === modified file 'storage/innobase/include/os0sync.h'
> --- a/storage/innobase/include/os0sync.h        2014-09-08 15:10:48 +0000
> +++ b/storage/innobase/include/os0sync.h        2014-11-18 08:07:42 +0000
>


>  #ifdef __powerpc__
> -# define os_isync  __asm __volatile ("isync":::"memory")
> +# define os_isync __atomic_thread_fence(__ATOMIC_SEQ_CST)
>

you have to rename to the #define too (e.g to os_mb).
having a os_isync which is infact a mb is more obfuscation
than anyone should have to put up with.

/Jonas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.askmonty.org/pipermail/commits/attachments/20141118/d229b55a/attachment-0001.html>


More information about the commits mailing list