[Commits] Rev 3543: Remove unneeded comments in file:///data0/psergey/dev2/5.5-show-explain-r34/

Sergey Petrunya psergey at askmonty.org
Sun Nov 4 21:36:59 EET 2012


At file:///data0/psergey/dev2/5.5-show-explain-r34/

------------------------------------------------------------
revno: 3543
revision-id: psergey at askmonty.org-20121006071059-jztgqnndoniuy4ef
parent: psergey at askmonty.org-20121006070918-01y2l86jdkav7fs4
committer: Sergey Petrunya <psergey at askmonty.org>
branch nick: 5.5-show-explain-r34
timestamp: Sat 2012-10-06 11:10:59 +0400
message:
  Remove unneeded comments
=== modified file 'sql/sql_select.cc'
--- a/sql/sql_select.cc	2012-10-06 07:03:37 +0000
+++ b/sql/sql_select.cc	2012-10-06 07:10:59 +0000
@@ -19038,14 +19038,6 @@
   /* Currently ORDER BY ... LIMIT is not supported in subqueries. */
   DBUG_ASSERT(join->group_list || !join->is_in_subquery());
 
-  /* 
-    If we have a select->quick object that is created outside of
-    create_sort_index() and this is part of a subquery that
-    potentially can be executed multiple times then we should not
-    delete the quick object on exit from this function.
-  */
-  //bool keep_quick= select && select->quick && join->join_tab_save;
-
   /*
     When there is SQL_BIG_RESULT do not sort using index for GROUP BY,
     and thus force sorting on disk unless a group min-max optimization
@@ -19097,7 +19089,6 @@
 			    get_quick_select_for_ref(thd, table, &tab->ref, 
                                                      tab->found_records))))
 	goto err;
-      //DBUG_ASSERT(!keep_quick);//psergey-post-merge-check
       quick_created= TRUE;
     }
   }
@@ -19145,6 +19136,7 @@
   /*TODO: here, close the index scan, cancel index-only read. */
   tab->records= table->sort.found_records;	// For SQL_CALC_ROWS
 #if 0 
+  /* MariaDB doesn't need the following: */
   if (select)
   {
     /*



More information about the commits mailing list