[Commits] Rev 3158: MWL#182: Explain running statements in file:///home/psergey/dev2/5.3-show-explain-r2/

Sergey Petrunya psergey at askmonty.org
Thu Aug 25 11:15:31 EEST 2011


At file:///home/psergey/dev2/5.3-show-explain-r2/

------------------------------------------------------------
revno: 3158
revision-id: psergey at askmonty.org-20110825081529-5j5u4ul8jtnepbti
parent: psergey at askmonty.org-20110824104113-af61bexgg44lwkcs
committer: Sergey Petrunya <psergey at askmonty.org>
branch nick: 5.3-show-explain-r2
timestamp: Thu 2011-08-25 12:15:29 +0400
message:
  MWL#182: Explain running statements
  - Added TODO comments
=== modified file 'mysql-test/t/show_explain.test'
--- a/mysql-test/t/show_explain.test	2011-08-24 10:41:13 +0000
+++ b/mysql-test/t/show_explain.test	2011-08-25 08:15:29 +0000
@@ -43,4 +43,9 @@
 
 #insert into t1 values ('one'),('two'),('three');
 
+## TODO: Test this: multiple SHOW EXPLAIN calls in course of running of one select
+## 
+## TODO: Test this: have several SHOW EXPLAIN requests be queued up for a
+##       thread and served together.
+
 drop table t0,t1;

=== modified file 'sql/my_apc.cc'
--- a/sql/my_apc.cc	2011-08-23 15:28:32 +0000
+++ b/sql/my_apc.cc	2011-08-25 08:15:29 +0000
@@ -97,7 +97,9 @@
 /*
   Make an apc call in another thread. The caller is responsible so 
   that we're not calling to ourselves.
-
+  
+  psergey-todo: Should waits here be KILLable? (it seems one needs 
+  to use thd->enter_cond() calls to be killable)
 */
 
 bool Apc_target::make_apc_call(apc_func_t func, void *func_arg, 



More information about the commits mailing list