[Commits] Rev 3169: Fix bug lp:1009187, mdev-373, mysql bug#58628 in file:///home/tsk/mprog/src/5.2/

Oleksandr Byelkin sanja at montyprogram.com
Thu Sep 13 18:11:53 EEST 2012


13.09.2012 15:25, timour at askmonty.org пишет:
> At file:///home/tsk/mprog/src/5.2/
>
> ------------------------------------------------------------
> revno: 3169
> revision-id: timour at askmonty.org-20120913122237-wwhy9xfcz2izn0wv
> parent: knielsen at knielsen-hq.org-20120824171247-1vlaykehbsob9stg
> fixes bug(s): https://launchpad.net/bugs/1009187
> committer: timour at askmonty.org
> branch nick: 5.2
> timestamp: Thu 2012-09-13 15:22:37 +0300
> message:
>    Fix bug lp:1009187, mdev-373, mysql bug#58628
Hi!

The patch is OK. Thank you. The only problem is following (2 times):

+      DBUG_RETURN(1); /* NULL value, not error. TODO: why? */

Actually it is not direct setting NULL (in theory it could be any value 
set by reset() method). exec() of subquery pass it "as is" and val_* 
family of methods call reset() in case of error (or TRUE). IMHO we have 
to add in descriptions of all involved exec() that TRUE means reset not 
an error (as it was originally).


More information about the commits mailing list